Skip to contentSkip to conversation

Change in openvpn[master]: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

Openvpn-devel In review flichtenheld (Code Review) 2 participants 6 messages Apr 4 – Apr 5 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): gerrit.1775328983000.I04a01cf536ee6d48d54ba623dda460c4a98859f9@...2715...

#1 lore raw

Attention is currently required from: plaisthos.

Hello plaisthos,

I'd like you to do a code review.
Please visit

    http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email

to review the following change.

Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready
......................................................................

mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended.

Found by cppcheck.

Change-Id I04a01cf536ee6d48d54ba623dda460c4a98859f9

---
M src/openvpn/mtcp.c

1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/09/1609/1

src/openvpn/mtcp.c +0 -4
index 2eab7b7..7651b4d 100644
@@ -155,10 +155,6 @@
         ASSERT(mi == item.instance);
         mi->context.c2.to_link = item.buffer->buf;
         ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags);
-        if (!ret)
-        {
-            mi = NULL;
-        }
         mbuf_free_buf(item.buffer);
     }
     return ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>

#2 lore raw
In reply to a message not in the archive

Attention is currently required from: flichtenheld, plaisthos.

cron2 has posted comments on this change by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email )

Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready
......................................................................

Patch Set 1: Code-Review+2

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Sat, 04 Apr 2026 20:33:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes

#3 lore raw

PATCH 1/1 mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

In reply to a message not in the archive

From: Frank Lichtenheld <[email protected]...>

Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended.

Found by cppcheck.

Change-Id I04a01cf536ee6d48d54ba623dda460c4a98859f9

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609
---

This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609
This mail reflects revision 1 of this Change.

Acked-by according to Gerrit (reflected above):
Gert Doering <[email protected]...>

src/openvpn/mtcp.c +0 -4
index 2eab7b7..7651b4d 100644
@@ -155,10 +155,6 @@
         ASSERT(mi == item.instance);
         mi->context.c2.to_link = item.buffer->buf;
         ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags);
-        if (!ret)
-        {
-            mi = NULL;
-        }
         mbuf_free_buf(item.buffer);
     }
     return ret;
#4 lore raw

[Openvpn-devel] [PATCH applied] Re: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

Another good catch :-) - and indeed, stare-at-code confirms your and cppcheck's analysis. Dead code. From the dark times. As for the last patch, "master only" unless we want release/2.7 to be cppcheck-clean.

Your patch has been applied to the master branch.

commit d44ed886c279de51a936cc0652c9b72c943a6558

Author: Frank Lichtenheld
Date:   Sat Apr 4 22:33:30 2026 +0200
     mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

     Signed-off-by: Frank Lichtenheld <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/[email protected]/msg36478.html
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#5 lore raw
In reply to a message not in the archive

cron2 has uploaded a new patch set (#2) to the change originally created by flichtenheld. ( http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email )

The following approvals got outdated and were removed:
Code-Review+2 by cron2

Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready
......................................................................

mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended.

Found by cppcheck.

Change-Id I04a01cf536ee6d48d54ba623dda460c4a98859f9

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36478.html

---
M src/openvpn/mtcp.c

1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/09/1609/2

src/openvpn/mtcp.c +0 -4
index 2eab7b7..7651b4d 100644
@@ -155,10 +155,6 @@
         ASSERT(mi == item.instance);
         mi->context.c2.to_link = item.buffer->buf;
         ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags);
-        if (!ret)
-        {
-            mi = NULL;
-        }
         mbuf_free_buf(item.buffer);
     }
     return ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>

#6 lore raw
In reply to a message not in the archive

cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email )

Change subject: mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready
......................................................................

mtcp: Remove noop statement in multi_tcp_process_outgoing_link_ready

Assigning to a parameter here has no effect. I can see no obvious alternative statement that might have been intended.

Found by cppcheck.

Change-Id I04a01cf536ee6d48d54ba623dda460c4a98859f9

Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1609
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg36478.html

---
M src/openvpn/mtcp.c

1 file changed, 0 insertions(+), 4 deletions(-)
src/openvpn/mtcp.c +0 -4
index 2eab7b7..7651b4d 100644
@@ -155,10 +155,6 @@
         ASSERT(mi == item.instance);
         mi->context.c2.to_link = item.buffer->buf;
         ret = multi_process_outgoing_link_dowork(m, mi, mpp_flags);
-        if (!ret)
-        {
-            mi = NULL;
-        }
         mbuf_free_buf(item.buffer);
     }
     return ret;

--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/1609?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I04a01cf536ee6d48d54ba623dda460c4a98859f9
Gerrit-Change-Number: 1609
Gerrit-PatchSet: 2
Gerrit-Owner: flichtenheld <[email protected]...>
Gerrit-Reviewer: cron2 <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>